6 stage - Emelyanov Vitaliy, SPbSTU #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
I checked gst today and seen there uncommited report file I understand if you wouldn't check that, it's my mistake Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Signed-off-by: vitaliy.emelyanov <[email protected]>
Signed-off-by: vitaliy.emelyanov <[email protected]>
lamtev
approved these changes
May 9, 2024
| if (result == null) { | ||
| httpSession.sendResponse(new Response(Response.INTERNAL_ERROR, Response.EMPTY)); | ||
| } else { | ||
| httpSession.write(new HttpChunkedHeaderQueueItem()); |
There was a problem hiding this comment.
Можно ли было бы сделать константой этот объект с целью уменьшений количества аллокаций? И HttpChunkedEntry
Не приложены профили, к сожалению, не посмотреть, видно ли на них эти аллокации
|
|
||
| public ByteQueueItem(byte[] bytes) { | ||
| this.bytes = Arrays.copyOf(bytes, bytes.length); | ||
| // я не хотел копировать тут, меня заставил код стайл( |
There was a problem hiding this comment.
как вариант, если есть уверенность в безопасности, можно было бы попробовать вынести в функцию типа byte[] haha(byte[] b) { return b; } или добавить @SuppressWarning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.